fix(spans): Max description length #3115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
commented
Feb 15, 2024
Comment on lines
+45
to
+48
| relay_log::error!( | ||
| description = description, | ||
| "Span description too large to parse" | ||
| ); |
There was a problem hiding this comment.
We can remove this error at a later point.
iker-barriocanal
approved these changes
Feb 15, 2024
olksdr
approved these changes
Feb 15, 2024
This was referenced Feb 15, 2024
jjbayer
added a commit
that referenced
this pull request
Feb 16, 2024
All stack overflows after upgrading to sqlparser 0.43 occurred in `.clone()`, not during parsing (see [POP-RELAY-30P](https://sentry.my.sentry.io/organizations/sentry/issues/645286/)). We cloned the parsed query to reuse it for table name extraction. But table name extraction should work just as well on the scrubbed query, so the clone is unnecessary. This PR also reverts #3115. ref: getsentry/team-ingest#272
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not attempt to parse very long span description.
This should prevent stack overflows in the SQL parser.
We could also limit the length of the description field by setting a
bag_sizeattribute on it. Unfortunately, theTrimmingProcessorruns after other normalization steps, so it would not help in this case.ref: https://github.com/getsentry/team-ingest/issues/272