feat(spans): Add SDK information to spans #3178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to make our some of our reporting dashboards, we'd need to know which SDKs generated the spans. This PR aims to add those 2 fields as Sentry tags. We'll then extract the values to store in BigQuery. They will be ingested by the Snuba consumer since they're part of Sentry tags now.
At the same time, in order to avoid a costly join on project ID, we're adding the organization ID to the Kafka payload. This field will not be used by the Snuba consumer, only SBC for data ingestion into BigQuery.
We're also adding
platform, a field necessary for performance issue detection later in the process. It will also be ingested as part of Sentry tags in ClickHouse.