ref(cardinality): Passive mode per cardinality limit #3199
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/ref/cardinality-mode
branch
from
768b4f3 to
81f7fb0
Compare
olksdr
approved these changes
Mar 5, 2024
jjbayer
approved these changes
Mar 5, 2024
| &Item::new(4, MetricNamespace::Custom), | ||
| ]) | ||
| ); | ||
| drop(rejected); // NLL are broken here without the explicit drop |
There was a problem hiding this comment.
Non lexical lifetimes.
The compiler should be smart enough to see that rejected is no longer used, but without the drop I cannot call into_accepted because there is still the reference to rejected.
| pub fn enforced_limits(&self) -> &HashSet<&'a str> { | ||
| /// | ||
| /// This includes passive limits. | ||
| pub fn limits(&self) -> &HashSet<&'a CardinalityLimit> { |
There was a problem hiding this comment.
Suggested change
| pub fn limits(&self) -> &HashSet<&'a CardinalityLimit> { | |
| pub fn exceeded_limits(&self) -> &HashSet<&'a CardinalityLimit> { |
There was a problem hiding this comment.
I'll do that in a follow-up, I need. a librelay release to continue and I don't feel like waiting another 30 minutes...
This was referenced Mar 5, 2024
Dav1dde
added a commit
that referenced
this pull request
Mar 5, 2024
) Followup of #3199 Renames the `limits` fn to a better name, adds changelog and librelay changelog entry (project config is affected).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it possible to mark individual cardinality limits per project to be marked as passive.
Initially the idea was not to add the
passiveflag to the individual limit and only enforce the passive property/mode in the processor. But it turns out this is more complicated than just directly discarding a passive result in the cardinality limiter. This was made easy due to already having the correct abstraction (Rejectionstrait) in place, it just needed to be slightly updated to be passed the limit instead of just the limit id. This approach also allows us to tag all metrics and cardinality errors with a passive tag.#skip-changelog