fix(spans): Emit a usage metric for every span seen #3209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mitsuhiko
approved these changes
Mar 4, 2024
iker-barriocanal
approved these changes
Mar 5, 2024
Dav1dde
approved these changes
Mar 5, 2024
Co-authored-by: Joris Bayer <[email protected]>
phacops
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've made it so we emit a usage metric for each span we extract a metric for which in turns will be used to emit a processed span outcome.
We'd like to change this to emit a usage metric for every span we see as Relay is still processing those spans even if it's not to store derived data from them. This has some impact for billing.
As we improve the product, we anticipate to store more and more information regarding those spans and the overall cost for the customer will not change.