Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(profiling): add segment_id to the profile #3265

Merged
merged 7 commits into from
Mar 14, 2024
Merged

ref(profiling): add segment_id to the profile #3265

merged 7 commits into from
Mar 14, 2024

Conversation

viglia
Copy link
Contributor

@viglia viglia commented Mar 13, 2024 •
edited
Loading

Pass the segment_id, which is the span_id of the root span, down to the profile.

@viglia viglia marked this pull request as ready for review March 13, 2024 19:03
@viglia viglia requested a review from a team as a code owner March 13, 2024 19:03
@viglia viglia requested a review from a team March 13, 2024 19:10
jjbayer
jjbayer reviewed Mar 14, 2024
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@viglia could you please add a description to the PR?

relay-profiling/src/android.rs Show resolved Hide resolved
@viglia viglia requested a review from jjbayer March 14, 2024 10:17
jjbayer
jjbayer approved these changes Mar 14, 2024
View reviewed changes
Copy link
Member

@jjbayer jjbayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See open comments.

CHANGELOG.md Outdated Show resolved Hide resolved
relay-event-schema/src/protocol/contexts/trace.rs Outdated Show resolved Hide resolved
relay-profiling/src/android.rs Show resolved Hide resolved
@viglia viglia merged commit fca9105 into master Mar 14, 2024
20 checks passed
@viglia viglia deleted the viglia/ref/pass-segment-id-to-profiles branch March 14, 2024 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

Assignees

@viglia viglia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viglia @jjbayer