feat(spans): Route spans according to trace_id #3387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phacops
changed the title
jjbayer
reviewed
Apr 8, 2024
relay-server/src/services/store.rs
Outdated
| @@ -1378,16 +1378,15 @@ struct SpanKafkaMessage<'a> { | |||
| /// Number of days until these data should be deleted. | |||
| #[serde(default)] | |||
| retention_days: u16, | |||
| #[serde(default, skip_serializing_if = "Option::is_none")] | |||
| segment_id: Option<&'a str>, | |||
| segment_id: &'a str, | |||
There was a problem hiding this comment.
We deserialize a SpanKafkaMessage from a Span, right? Can we be sure that it has a segment_id?
There was a problem hiding this comment.
Reverted since we're using trace_id and not segment_id for routing.
jjbayer
approved these changes
Apr 9, 2024
iker-barriocanal
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're in need of buffering spans later in the pipeline and it helps to have them on the same partition. We only need them routed per
segment_idbut since it's not aUuid, usingtrace_idis simpler. An alternative would be to properly transform thesegment_idinto au64and then callUuid::from_u64_pair(segment_id, 0)but that seems unnecessary.