Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(relay-cabi): Expose cardinality limit validation #3489

Merged
merged 5 commits into from
Apr 30, 2024
Merged

feat(relay-cabi): Expose cardinality limit validation #3489

merged 5 commits into from
Apr 30, 2024

Conversation

ArthurKnaus
Copy link
Member

@ArthurKnaus ArthurKnaus commented Apr 26, 2024 •
edited
Loading

Expose relay_validate_cardinality_limit_config to enable validation in sentry repo.

Relates to getsentry/sentry#69750

#skip-changelog

@ArthurKnaus ArthurKnaus requested a review from a team as a code owner April 26, 2024 09:35
@ArthurKnaus ArthurKnaus changed the title feat(relay-cabi): Export cardinality limit validation feat(relay-cabi): Expose cardinality limit validation Apr 26, 2024
iker-barriocanal
iker-barriocanal reviewed Apr 26, 2024
View reviewed changes
Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

py/tests/test_processing.py Outdated Show resolved Hide resolved
py/tests/test_processing.py Outdated Show resolved Hide resolved
@ArthurKnaus
Copy link
Member Author

@iker-barriocanal thx for the review, I changed the implementation to the normalization approach 👍
btw how do I resolve the Changelog check? I already added an entry in py/CHANGELOG.md 🤔

iker-barriocanal
iker-barriocanal approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@iker-barriocanal iker-barriocanal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, please see comments before merging.

A #skip-changelog in the PR description skips the changelog checks. This is ok as there's already an entry in py/changelog and that's all we need.

py/CHANGELOG.md Outdated Show resolved Hide resolved
relay-cabi/src/processing.rs Outdated Show resolved Hide resolved
@ArthurKnaus ArthurKnaus merged commit 1f60882 into master Apr 30, 2024
26 checks passed
@ArthurKnaus ArthurKnaus deleted the aknaus/feat/relay-cabi/export-cardinality-limit-validation branch April 30, 2024 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iker-barriocanal iker-barriocanal iker-barriocanal approved these changes

Assignees

@ArthurKnaus ArthurKnaus

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ArthurKnaus @iker-barriocanal