ref(ds): Low cardinality outcome reason #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjbayer
force-pushed
the
ref/sampling-low-cardinality-reason
branch
from
88167fa to
9029c48
Compare
matejminar
approved these changes
May 17, 2024
relay-server/src/services/outcome.rs
Outdated
| 1003 => Self::BoostKeyTransactions, | ||
| 1004 => Self::Recalibration, | ||
| 1005 => Self::BoostReplayId, | ||
| n if (1400..1500).contains(&n) => Self::BoostLowVolumeTransactions, |
There was a problem hiding this comment.
Is this 1400 including and 1500 excluding? If yes, then we're good 👍
Same question for BoostLatestReleases and Custom.
There was a problem hiding this comment.
Yes! I had a more explicit n >= 1400 && n < 1500 condition here first, but the rust linter is very opinionated.
The range
start..endcontains all values withstart <= x < end
(docs)
Dav1dde
approved these changes
May 17, 2024
relay-server/src/services/outcome.rs
Outdated
| 1003 => Self::BoostKeyTransactions, | ||
| 1004 => Self::Recalibration, | ||
| 1005 => Self::BoostReplayId, | ||
| n if (1400..1500).contains(&n) => Self::BoostLowVolumeTransactions, |
There was a problem hiding this comment.
Suggested change
| n if (1400..1500).contains(&n) => Self::BoostLowVolumeTransactions, | |
| 1400..=1499 => Self::BoostLowVolumeTransactions, |
And for the following lines the same.
relay-server/src/services/outcome.rs
Outdated
| } | ||
|
|
||
| impl RuleCategory { | ||
| fn to_str(self) -> &'static str { |
There was a problem hiding this comment.
Suggested change
| fn to_str(self) -> &'static str { | |
| fn as_str(self) -> &'static str { |
We have as_str throughout Relay for enums
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reduce noise in outcome reasons by mapping ranges of dynamic sampling rule IDs together, and ordering them. That is