Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(spans): Also write inp metrics to transactions name space #3641

Conversation

edwardgou-sentry
Copy link
Contributor

Right now INP metrics are span metric distributions with percentiles. We rely on these percentiles in the product UI.

There are plans to disable storing percentiles for distributions under the spans namespace, so we must move INP metrics to the transactions namespace as a workaround to keep INP percentiles. The plan is to extract these transaction namespace INP metrics for 90 days until we have enough data to switch over and deprecate the spans namespace INP metrics.

@edwardgou-sentry edwardgou-sentry marked this pull request as ready for review May 23, 2024 21:08
@edwardgou-sentry edwardgou-sentry requested a review from a team as a code owner May 23, 2024 21:08
@edwardgou-sentry edwardgou-sentry requested a review from phacops May 23, 2024 21:08
@edwardgou-sentry edwardgou-sentry self-assigned this May 23, 2024
Comment on lines +556 to +557
mri: "d:transactions/webvital.score.total@ratio".into(),
field: Some("span.measurements.score.total.value".into()),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is already extracted as d:transactions/measurements.score.total@ratio (PR):

mri: "d:transactions/measurements.score.total@ratio".into(),
field: Some("span.measurements.score.total.value".into()),

@edwardgou-sentry can we get rid of d:transactions/measurements.score.total@ratio in favor of the new d:transactions/webvital.score.total@ratio? Or is the one with measurements. still used by the product? Asking because the measurements. one has caused problems before.

Either way we should keep only one of the two metrics.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I think you're right, we probably don't need two of these

Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, will leave it to @phacops for the final approval.

@edwardgou-sentry
Copy link
Contributor Author

edwardgou-sentry commented May 24, 2024

I've heard that the team is now planning to make an exception to keep percentiles for the inp metric (d:spans/webvital.inp@millisecond). So we actually do not need this change anymore 😅

Closing this pr for now, but we can reopen and discuss if it becomes needed again

@jan-auer jan-auer deleted the egou/feat/write-inp-metrics-to-transactions-name-space branch July 4, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants