-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(profiles): Support profiler_id in context #3714
feat(profiles): Support profiler_id in context #3714
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work, the context is recreated in transfer_id
:
relay/relay-server/src/services/processor/profile.rs
Lines 66 to 87 in bdb89f2
pub fn transfer_id( | |
state: &mut ProcessEnvelopeState<TransactionGroup>, | |
profile_id: Option<ProfileId>, | |
) { | |
let Some(event) = state.event.value_mut() else { | |
return; | |
}; | |
match profile_id { | |
Some(profile_id) => { | |
let contexts = event.contexts.get_or_insert_with(Contexts::new); | |
contexts.add(ProfileContext { | |
profile_id: Annotated::new(profile_id), | |
}); | |
} | |
None => { | |
if let Some(contexts) = event.contexts.value_mut() { | |
contexts.remove::<ProfileContext>(); | |
} | |
} | |
} | |
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move the thread id/name changes to a separate PR
86dfdf8
to
fb3bc7f
Compare
* master: chore(dynamic-sampling): Remove metrics for dsc tracking (#3766) feat(web-vitals): add support for mobile browsers (#3762) feat(profiles): Support profiler_id in context (#3714) ref(normalization): Add origin and event_type tags to normalization decision (#3764) feat(rate-limiting): Add back docs with examples on rate limiting (#3761) feat(spans): Correctly emit negative outcomes for rate limited transactions that have nested spans (#3749) ref(metrics): Remove unused sentry extra data (#3758) feat(statsd): Emit tokio runtime metrics via statsd (#3755) ref(metrics): Aggregate metrics before rate limiting (#3746) ref(cogs): Remove unused metric, revert to released usage accountant (#3756) build(cargo): Update curve25519-dalek from 4.0.0 to 4.1.3 (#3745) test(deps): Bump requests from 2.31.0 to 2.32.2 (#3752)
As part of continuous profiling, we need to store a
profiler_id
on the profile context of a transaction.