ref(profiles): Process profiles before metric extraction #3767
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/profile-metrics-order
branch
2 times, most recently
from
7ee1c52 to
631f80e
Compare
Dav1dde
force-pushed
the
dav1d/profile-metrics-order
branch
from
631f80e to
db5be89
Compare
Dav1dde
force-pushed
the
dav1d/profile-metrics-order
branch
from
db5be89 to
a18e44e
Compare
jjbayer
approved these changes
Jun 27, 2024
iker-barriocanal
approved these changes
Jun 27, 2024
| profile::process(state, &self.inner.config); | ||
| } | ||
| // Before metric extraction to make sure the profile count is reflected correctly. | ||
| let profile_id = match keep_profiles { |
There was a problem hiding this comment.
Is this easier to read than if..else?
There was a problem hiding this comment.
One line less and personally for me it reads nicer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invalid profiles with a valid header which are ultimately discarded as invalid would still tag the transaction usage metric with
has_profile, even though the profile was dropped.process::transfer_idintoprocess::filter