ref(spans): Remove conversion to transaction #3801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
approved these changes
Jul 9, 2024
jan-auer
approved these changes
Jul 9, 2024
| /// | ||
| /// Serialized as `projects:extract-transaction-from-segment-span`. | ||
| #[serde(rename = "projects:extract-transaction-from-segment-span")] | ||
| ExtractTransactionFromSegmentSpan, |
There was a problem hiding this comment.
We used to keep these features as "deprecated". This is not serving too much of a purpose these days, but I still wanted to point this out. If we no longer plan to do this, let's also remove the other deprecated features in a follow-up.
There was a problem hiding this comment.
Good point, in this case I believe removing the feature flag is OK though, because it was effectively only read in processing relays and removing it does not change the behavior of outdated external relays.
jjbayer
added a commit
to getsentry/sentry
that referenced
this pull request
Jul 9, 2024
priscilawebdev
pushed a commit
to getsentry/sentry
that referenced
this pull request
Jul 11, 2024
0Calories
pushed a commit
that referenced
this pull request
Jul 11, 2024
Double-writing segment spans as transactions was meant as a temporary measure to transition to the spans dataset in the product. The feature was never used by more than a handful of projects and can now be removed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Double-writing segment spans as transactions was meant as a temporary measure to transition to the spans dataset in the product. The feature was never used by more than a handful of projects and can now be removed.