feat(spans): extract country code into spans #3911
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work towards getsentry/sentry#75230
This PR adds country_code as an indexed span tag. Eventually we would like to create regional metrics, but we have to make a product decision on whether we want country based metrics, or larger region metrics (ex. continent). There are also ~200 countries, which could be high cardinality wise, but at least we have a known limit (lmk if you have thoughts on this!)