feat(spans): extract user.geo.geoscheme metrics #3914
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
reviewed
Aug 9, 2024
relay-event-normalization/src/normalize/span/country_subregion.rs
Outdated
Show resolved
Hide resolved
relay-event-normalization/src/normalize/span/country_subregion.rs
Outdated
Show resolved
Hide resolved
relay-event-normalization/src/normalize/span/country_subregion.rs
Outdated
Show resolved
Hide resolved
Dav1dde
reviewed
Aug 12, 2024
relay-event-normalization/src/normalize/span/country_subregion.rs
Outdated
Show resolved
Hide resolved
relay-event-normalization/src/normalize/span/country_subregion.rs
Outdated
Show resolved
Hide resolved
relay-event-normalization/src/normalize/span/country_subregion.rs
Outdated
Show resolved
Hide resolved
Dav1dde
approved these changes
Aug 12, 2024
edwardgou-sentry
approved these changes
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work towards getsentry/sentry#75230
This tags appropriate metrics with subregion as defined by the UN m49 standard. (There are many sources for this, for example see the tree under https://localizely.com/un-m49-list/). This allows us to filter down data by region within insight modules so that we can understand performance by region.
Originally we were hoping to use country codes, but due to cardinality concerns, we opted for larger regions. There are a total of 22 geographical subregions vs 200+ countries.
Note: I'm going to go through and double check all the mapping, but any early reviews of the implementation would be greatly appreciated.