ref(profiling): forward profiles of non-sampled transactions (with no options filtering) #3963
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove the options to shutdown, filter by platform or downsample the number of processed profiles we pass along to extract the metrics.
viglia
commented
Aug 28, 2024
jjbayer
reviewed
Aug 29, 2024
@jjbayer yes, generally speaking we're sure we want to forward all the processed profiles for the foreseeable future. Still, I agree that we should still keep the global kill switch, in case it's ever needed. I'll put that one back 👍🏻 |
add back `profiling.profile_metrics.unsampled_profiles.enabled` global kill switch.
viglia
changed the title
…and-ingest-all-unsampled-profiles
jjbayer
reviewed
Aug 29, 2024
add deprecated feature for projects:profiling-ingest-unsampled-profiles
define the following as deprecated: * `profiling.profile_metrics.unsampled_profiles.platforms` * `profiling.profile_metrics.unsampled_profiles.sample_rate`
jjbayer
approved these changes
Aug 29, 2024
…and-ingest-all-unsampled-profiles
viglia
deleted the
viglia/ref/remove-options-and-ingest-all-unsampled-profiles
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the options to shutdown, filter by platform or downsample the number of processed profiles we pass along to extract the metrics.
With this, all the
Processed Profiles(that are not indexed), will be passed along, as we currently do, but without the further checks that are currently in place (rollout rate, platforms, etc.).The global kill-switch is left, should we ever need it in case of incidents.