Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(spans): Remove the otel spans endpoint #3973

Merged
merged 4 commits into from
Sep 2, 2024

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Sep 2, 2024

SDKs send spans exclusively through envelopes. We confirmed this design decision
and are not going to offer a direct otel endpoint in the near future. Hence, the
spans endpoint is being removed from Relay.

cc @HazAT

@jan-auer jan-auer requested a review from a team as a code owner September 2, 2024 11:50
@jan-auer jan-auer self-assigned this Sep 2, 2024
Copy link
Member

@sl0thentr0py sl0thentr0py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine with me, maybe ask @phacops for a stamp too

@sl0thentr0py sl0thentr0py requested a review from phacops September 2, 2024 11:51
@jan-auer jan-auer merged commit 44186da into master Sep 2, 2024
24 checks passed
@jan-auer jan-auer deleted the ref/remove-spans-endpoint branch September 2, 2024 13:21
jjbayer added a commit that referenced this pull request Nov 5, 2024
jjbayer added a commit that referenced this pull request Nov 19, 2024
Restore the OTLP endpoint that was removed in
#3973.

This PR moves the parsing of the trace data to the processor to ensure
fast response times.

I also renamed the endpoint from `/spans/` to `/otlp/v1/traces/` to be
consistent with
https://opentelemetry.io/docs/languages/sdk-configuration/otlp-exporter/#otel_exporter_otlp_endpoint.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants