feat(spans): only extract user.geo.subregion if mobile or frontend project #4013
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DominikB2014
commented
Sep 6, 2024
| @@ -178,6 +178,7 @@ expression: metrics | |||
| "transaction": "gEt /api/:version/users/", | |||
| "transaction.method": "POST", | |||
| "transaction.op": "myop", | |||
| "user.geo.subregion": "155", | |||
There was a problem hiding this comment.
Something to note here, this was added here because we added the browser context to the test event, if the browser context was missing, these tags would not be added to any spans.
DominikB2014
deleted the
DominikB2014/only-capture-geo-location-backend-mobile
branch
DominikB2014
added a commit
that referenced
this pull request
Sep 11, 2024
This is an extension of this PR #4013 I assumed that Backend SDK transactions would not have a browser context, so i used that as a means to check if the project is a frontend project. Turns out, python SDKs still set browser context on the transaction (I guess this is the browser the user made the request from?). So to fix this, we can just check the platform directly as frontend is typically/always javascript. --------- Co-authored-by: Joris Bayer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
work towards getsentry/sentry#75230
We saw a noticeable increase in clickhouse rows after tagging spans with
user.geo.subregion. However, this feature is only intended for frontend and mobile, so it makes sense we just don't allow other SDKs to extract these tags.This should help a lot, if you look at the sentry org, the sentry backend project emits a most 330k http spans per minute, while the frontend emits at most 30k.