Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pattern): Incorrect matches with adjacent any and wildcard matchers #4072

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Sep 24, 2024

Joining ? with * is an invalid optimization, the ? implicitly forces a minimum length match, where as * matches 0..N characters.

@Dav1dde Dav1dde requested a review from a team as a code owner September 24, 2024 11:26
@Dav1dde Dav1dde self-assigned this Sep 24, 2024
@Dav1dde Dav1dde merged commit e09b7e1 into master Sep 24, 2024
23 checks passed
@Dav1dde Dav1dde deleted the dav1d/pattern-any-wildcard branch September 24, 2024 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants