Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(unreal): Add support for LoginId in Unreal Crash Context #4093

Merged
merged 5 commits into from
Oct 3, 2024

Conversation

tobias-wilfert
Copy link
Member

@tobias-wilfert tobias-wilfert commented Oct 2, 2024

We only use the LoginId to set the user id if the id has not been previously set from the header.

Fixes: #4083

@tobias-wilfert tobias-wilfert self-assigned this Oct 2, 2024
@tobias-wilfert tobias-wilfert requested a review from a team as a code owner October 2, 2024 12:57
@tobias-wilfert tobias-wilfert changed the title WIP: Add support for the LoginId field. WIP: Add support for LoginId in Unreal Crash Context Oct 2, 2024
@tobias-wilfert tobias-wilfert changed the title WIP: Add support for LoginId in Unreal Crash Context Add support for LoginId in Unreal Crash Context Oct 2, 2024
@tobias-wilfert tobias-wilfert changed the title Add support for LoginId in Unreal Crash Context feat(): Add support for LoginId in Unreal Crash Context Oct 3, 2024
@tobias-wilfert tobias-wilfert changed the title feat(): Add support for LoginId in Unreal Crash Context feat(unreal): Add support for LoginId in Unreal Crash Context Oct 3, 2024
relay-server/src/utils/unreal.rs Outdated Show resolved Hide resolved
relay-server/src/utils/unreal.rs Show resolved Hide resolved
relay-server/src/utils/unreal.rs Outdated Show resolved Hide resolved
@tobias-wilfert tobias-wilfert merged commit 0746ff3 into master Oct 3, 2024
23 checks passed
@tobias-wilfert tobias-wilfert deleted the fix-unreal-user-count branch October 3, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unreal crash reporter issues no longer show user counts
2 participants