feat(server): Track a spans/count_per_root_project metric #4134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* master: ref(server): Move project source into the source module (#4154) instr(buffer): Measure envelope size (#4153) ref(redis): Cleanup code around Redis (#4151) lint: Rust 1.82 (#4150) chore(server): Remove native placeholders from transaction processing (#4148) feat(eap): Extract user IP (#4144) Revert "ref(buffer): remove peek" (#4146) ref(buffer): remove peek (#4136) release: 24.10.0 build(deps): bump tonic from 0.12.2 to 0.12.3 (#4143) instr(projects): Log fetch failure (#4142) ref(otel): Disable default features for otel schema (#4141) ref(server): Organize project services in nested modules (#4139) ref(redis): Update to redis client version 0.27.4 (#4132) feat(redis): Implement parallel cmd execution of Redis calls (#4118) feat(spooler): Add metric to track serialization performance (#4135)
iambriccardo
approved these changes
Oct 22, 2024
loewenheim
reviewed
Oct 22, 2024
Comment on lines
-52
to
+58
| spans_extracted: bool, | ||
| config: CombinedMetricExtractionConfig<'_>, | ||
| sampling_decision: SamplingDecision, | ||
| max_tag_value_size: usize, | ||
| span_extraction_sample_rate: Option<f32>, | ||
| ) -> Vec<Bucket> { | ||
| let mut metrics = generic::extract_metrics(event, config); | ||
| // If spans were already extracted for an event, we rely on span processing to extract metrics. | ||
| if !spans_extracted && sample(span_extraction_sample_rate.unwrap_or(1.0)) { | ||
| extract_span_metrics_for_event(event, config, max_tag_value_size, &mut metrics); | ||
| extract_spans: bool, |
There was a problem hiding this comment.
Here, extract_spans replaces the combination of spans_extracted and span_extraction_sample_rate, and sampling_decision is only used for tagging purposes further in, correct?
There was a problem hiding this comment.
Correct, the caller determines whether spans should be extracted, which comprises three conditions: The sample rate, whether spans were extracted before, and whether span extraction is enabled at all. That last condition is new and required because we want to skip the root counter metric.
sampling_decision is there purely for tagging the root counter metric, right.
Comment on lines
+222
to
+225
| relay_log::trace!( | ||
| span_count, | ||
| ?sampling_result, | ||
| "Dropped spans because of sampling rule", |
There was a problem hiding this comment.
I assume this log was moved here so there is only one log entry instead of one per span?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new metric
c:spans/count_per_root_project@nonethat tracks thenumber of spans per root project with a
transactionanddecisiontag. This will be used by span-based dynamic sampling for rebalancing.
The new metric is tracked in the two places where span metrics are
emitted, under the condition that span metric extraction features are
enabled:
Requires getsentry/sentry#78992
Closes https://github.com/getsentry/projects/issues/198