Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ref(metric-meta): Removes all metric meta code from Relay #4152

Merged
merged 3 commits into from
Oct 30, 2024
Merged

ref(metric-meta): Removes all metric meta code from Relay #4152

merged 3 commits into from
Oct 30, 2024

Conversation

Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Oct 18, 2024 •
edited
Loading

Metrics are soon to be shut down, this is one part of the code which is no longer required.

Existing metric-meta envelope items are handled as unknown from this version on forward.

@Dav1dde Dav1dde requested a review from a team as a code owner October 18, 2024 09:01
@Dav1dde Dav1dde force-pushed the dav1d/remove-metric-meta branch 2 times, most recently from 3691d66 to d6390d2 Compare October 18, 2024 09:06
iambriccardo
iambriccardo approved these changes Oct 18, 2024
View reviewed changes
Copy link
Member

@iambriccardo iambriccardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feels damn good, LGTM.

Only one question, when do we want to shut this down? I recall we will keep metrics enabled for some customers for an extended period of time.

@shellmayr
Copy link
Member

Feels damn good, LGTM.

Only one question, when do we want to shut this down? I recall we will keep metrics enabled for some customers for an extended period of time.

AFAIK Nov 7 at the earliest

@Dav1dde Dav1dde force-pushed the dav1d/remove-metric-meta branch from d6390d2 to 0333717 Compare October 18, 2024 09:14
@Dav1dde Dav1dde self-assigned this Oct 18, 2024
@Dav1dde Dav1dde force-pushed the dav1d/remove-metric-meta branch from 0333717 to d820891 Compare October 18, 2024 09:19
@Dav1dde Dav1dde force-pushed the dav1d/remove-metric-meta branch from acf88d4 to d5012d9 Compare October 21, 2024 13:06
@Dav1dde Dav1dde enabled auto-merge (squash) October 30, 2024 14:07
@Dav1dde Dav1dde merged commit 733363d into master Oct 30, 2024
23 checks passed
@Dav1dde Dav1dde deleted the dav1d/remove-metric-meta branch October 30, 2024 14:18
Dav1dde added a commit that referenced this pull request Oct 31, 2024
@Dav1dde
Revert "ref(metric-meta): Removes all metric meta code from Relay (#4152
5f84532 
)"

This reverts commit 733363d.
@Dav1dde Dav1dde mentioned this pull request Oct 31, 2024
Merged
Dav1dde added a commit that referenced this pull request Oct 31, 2024
@Dav1dde
ref(project-cache): Revert project cache split and metric meta removal (
c63be13 
#4198)

Revert of the PRs: #4147 and #4152 to unblock other deploys.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jjbayer jjbayer jjbayer approved these changes

@loewenheim loewenheim loewenheim approved these changes

@iambriccardo iambriccardo iambriccardo approved these changes

Assignees

@Dav1dde Dav1dde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Dav1dde @shellmayr @jjbayer @loewenheim @iambriccardo