Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(profiling): Profile chunk release is optional #4155

Merged
merged 5 commits into from
Oct 21, 2024
Merged

fix(profiling): Profile chunk release is optional #4155

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9e9c31f
fix(profiling): Profile chunk release is optional
Zylphrex Oct 18, 2024
f9208f0
update changelog
Zylphrex Oct 18, 2024
b0bcbf0
update changelog
Zylphrex Oct 18, 2024
f592182
address PR comments
Zylphrex Oct 21, 2024
7411a29
address PR comments
Zylphrex Oct 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- Report invalid spans with appropriate outcome reason. ([#4051](https://github.com/getsentry/relay/pull/4051))
- Use the duration reported by the profiler instead of the transaction. ([#4058](https://github.com/getsentry/relay/pull/4058))
- Incorrect pattern matches involving adjacent any and wildcard matchers. ([#4072](https://github.com/getsentry/relay/pull/4072))
- Profile chunk release is optional. ([#4155](https://github.com/getsentry/relay/pull/4155))
Zylphrex marked this conversation as resolved.
Show resolved Hide resolved

**Features:**

Expand Down
2 changes: 2 additions & 0 deletions relay-profiling/src/sample/v2.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ pub struct ProfileMetadata {
#[serde(skip_serializing_if = "Option::is_none")]
pub environment: Option<String>,
pub platform: String,

#[serde(default)]
pub release: String,
Zylphrex marked this conversation as resolved.
Show resolved Hide resolved

#[serde(skip_serializing_if = "Option::is_none")]
Expand Down
Loading