feat(metrics): Add target_project_id tag to root counter metrics #4170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
approved these changes
Oct 24, 2024
| pub universal_tags: CommonTags, | ||
| } | ||
|
|
||
| impl From<TransactionCPRTags> for BTreeMap<String, String> { | ||
| fn from(value: TransactionCPRTags) -> Self { | ||
| let mut map: BTreeMap<String, String> = value.universal_tags.into(); | ||
| map.insert("decision".to_string(), value.decision); | ||
| map.insert( | ||
| "target_project_id".to_string(), |
There was a problem hiding this comment.
Suggested change
| "target_project_id".to_string(), | |
| "target_project_id".to_owned(), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new tag named
target_project_idto thecount_per_root_projectmetrics in the spans and transactions namespace. The tag contains the numeric
identifier of the project where the transaction or spans are sent, in contrast
to the root project where the trace originated.
This tag is added so that we can track and display stats about the individual
data volume that flows from a root project into a specific target project.
The tag key will not be added to static strings in the metrics indexer.
Therefore, it will not be possible run cross-org queries that filter or group by
this tag.
Closes https://github.com/getsentry/projects/issues/224