Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ref(mongodb): Change grouping strategy for arrays and buffer #4186

Merged
merged 5 commits into from
Oct 30, 2024

Conversation

0Calories
Copy link
Member

@0Calories 0Calories commented Oct 28, 2024

Couple of changes here:

  • Arrays in MongoDB queries were problematic for grouping, because any variant of the same query that has a different number of elements would result in an entirely new group being created. This resulted in high cardinality for a few orgs
  • Removes the 'buffer' key-value pair from queries, since this is an under the hood mechanism which has very little relevance to the query itself. This causes unnecessary noise and makes queries hard to read, so we can scrub them out entirely

Examples

image

This would become:

"_id": {}

image
This would become:

"filter": {
	"_id": {
		"$in": ["..."]
	}
}

@0Calories 0Calories self-assigned this Oct 28, 2024
@0Calories 0Calories requested a review from a team as a code owner October 28, 2024 22:14
@0Calories 0Calories requested a review from mjq October 28, 2024 22:15
@0Calories 0Calories changed the title ref(mongodb): Change grouping strategy for arrays and buffer ref(mongodb): Change grouping strategy for arrays and buffer Oct 28, 2024
@0Calories 0Calories merged commit bc70b9e into master Oct 30, 2024
23 checks passed
@0Calories 0Calories deleted the ash/ref/mongodb-scrubbing-changes branch October 30, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants