fix(profiles): Rate limit profile chunks #4270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phacops
approved these changes
Nov 19, 2024
dashed
force-pushed
the
alberto/profile-chunk-rate-limit
branch
from
4ccb39a to
0ee7861
Compare
jjbayer
approved these changes
Nov 20, 2024
| # Configure rate limiting quota that blocks all profile durations and profile chunks at org level | ||
| project_config["quotas"] = [ | ||
| { | ||
| "categories": ["profile_duration", "profile_chunk"], |
There was a problem hiding this comment.
Would this test also pass with only "categories": ["profile_duration"]?
There was a problem hiding this comment.
This was for completeness as this would be the quota confi we would send from getsentry: https://github.com/getsentry/getsentry/pull/15734
viglia
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever we rate-limited profile chunks, we should not push the profile into the profile consumer.
I've also added/updated tests to verify this.