-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(outcomes): Do not report metrics-based outcomes for profiles #4365
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Should double check if we can find any other mention of has_profile
in (get)-sentry. I can't except in this test 👍 .
let has_profile = matches!(mri.name.as_ref(), "usage" | "duration") | ||
&& self.tags.has_profile.is_some(); | ||
BucketSummary::Transactions { count, has_profile } | ||
BucketSummary::Transactions(count) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can use the same formatting as for spans here:
MetricNamespace::Transactions => BucketSummary::Transactions(match self.value {
MinimalValue::Counter(c) if mri.name == "usage" => c.to_f64() as usize,
_ => 0,
}),
I found this constant, added in getsentry/sentry#64203. @wmak is that list based on alert definitions that people actually use? |
Decided we can merge this because the |
Profiles are no longer dropped by dynamic sampling, so we do not need to track the virtual "total profile" category with a tag on metrics.
This also prevents double-reporting (the rate limiter on the payload also emits an outcome for the
profile
category).ref: getsentry/sentry#81799