ref(spooler): Remove use of legacy project cache #4419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iambriccardo
commented
Dec 23, 2024
| pub own_key: ProjectKey, | ||
| pub sampling_key: ProjectKey, | ||
| own_key: ProjectKey, | ||
| sampling_key: Option<ProjectKey>, |
There was a problem hiding this comment.
I decided that I would prefer to encode in the pair the lack of sampling key and rather expose different methods for making it behave like before, where they were both set and the fallback of sampling_key was own_key.
…try/relay into riccardo/ref/remove-project-check
Dav1dde
reviewed
Jan 7, 2025
Comment on lines
20
to
26
| pub fn own_key(&self) -> ProjectKey { | ||
| self.own_key | ||
| } | ||
|
|
||
| pub fn sampling_key(&self) -> ProjectKey { | ||
| self.sampling_key | ||
| } |
There was a problem hiding this comment.
any downside of just keeping the fields public?
Comment on lines
479
to
481
| ProjectState::Pending => { | ||
| unreachable!("The own project should not be pending after pop"); | ||
| } |
There was a problem hiding this comment.
If we merge this with the above check for pending, this panic shouldn't be necessary
jjbayer
reviewed
Jan 7, 2025
Comment on lines
20
to
26
| pub fn own_key(&self) -> ProjectKey { | ||
| self.own_key | ||
| } | ||
|
|
||
| pub fn sampling_key(&self) -> ProjectKey { | ||
| self.sampling_key | ||
| } |
Dav1dde
approved these changes
Jan 8, 2025
jjbayer
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the old legacy project cache and implements the forwarding logic directly in the spooler. The new logic works as follows:
Follow-up work could include investigating how to reintroduce a bounded buffer between the buffer and the processor to prevent unspooling a large number of envelopes at once, which would accumulate in the processor queue. This option is not strictly necessary due to our memory threshold, which halts unspooling, but it may still be worth exploring.
Closes: #4335