feat(relay): Add span links to event schema #4486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lms24
commented
Feb 5, 2025
jjbayer
reviewed
Feb 5, 2025
Co-authored-by: Joris Bayer <[email protected]>
jjbayer
approved these changes
Feb 6, 2025
tests/integration/test_span_links.py
Outdated
| assert mini_sentry.captured_events.empty() | ||
|
|
||
|
|
||
| def test_event_with_span_links_in_child_span(relay, mini_sentry): |
There was a problem hiding this comment.
nit: You could probably merge these tests into one by having a transaction with both trace context links and child span links.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds span link definitions as spec'd out in RFC #141 to the
relay-event-schemacrate. As described in the envelope item payload section, span links can be added by SDKs inevent.contexts.trace.linksfor links of the root span/transactionevent.spans[i].linksfor links of child spansThis PR also adds integration tests for events with span links.
@reviewers, this is my first PR to Relay, so please let me know if I'm missing something or you want to see something else tested. Happy to make changes!
OpenAnswered questions:EDIT: Updated description with answered questions
closes #4443