feat(server): Apply clock-drift correction in proxy Relays #581
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
commented
May 18, 2020
| @@ -12,7 +12,7 @@ publish = false | |||
| [dependencies] | |||
| backoff = "0.1.5" | |||
| cadence = "0.17.1" | |||
| chrono = { version = "0.4.7", optional = true } | |||
| chrono = "0.4.7" | |||
There was a problem hiding this comment.
Went with a static dependency after all, like @untitaker suggested.
untitaker
approved these changes
May 18, 2020
HazAT
requested changes
May 18, 2020
Co-authored-by: Daniel Griesser <[email protected]>
HazAT
approved these changes
May 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes the
ClockDriftProcessorand applies it in non-processing mode. This allows for proper clock drift correction even when using proxy Relays that are in remote locations.This also contains a workaround for the current experimental JavaScript SDK (versions
5.2-5.15), which relies on clock drift correction withoutsent_at. In such a case, thesent_atvalue is inferred from the event's timestamp.