feat(general): Add SpanStatus to span struct #603
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
reviewed
Jun 3, 2020
There was a problem hiding this comment.
We could consider to move the span status into span.rs then, since it sounds like it belongs more there than in contexts.
Deferring to @untitaker for final review, he's the chief of spans.
untitaker
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
trace context and span status needs to be deduplicated, we just don't have serde(flatten) implemented to pull that off.
Since there are so many fields shared between trace context and the span struct I feel like it doesn't matter where the auxilliary types live
RaduW
pushed a commit
that referenced
this pull request
Jun 4, 2020
According to our dev docs at https://develop.sentry.dev/sdk/event-payloads/span/, status should be an explicit field on the span struct. The JS SDK is already setting it, and it is rendered for individual spans in the UI. Update the Span struct to have a field status. This is typed using SpanStatus, the same as the status on an event. Also updated the tests in the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
According to our dev docs at https://develop.sentry.dev/sdk/event-payloads/span/,
statusshould be an explicit field on the span struct. The JS SDK is already setting it, and it is rendered for individual spans in the UI.Implementation
Update the
Spanstruct to have a fieldstatus. This is typed usingSpanStatus, the same as the status on an event. Also updated the tests in the file.