Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(store): Normalize future_timestamp under 1 hour #654

Merged
merged 3 commits into from
Jul 8, 2020
Merged

fix(store): Normalize future_timestamp under 1 hour #654

merged 3 commits into from
Jul 8, 2020

Conversation

jan-auer
Copy link
Member

@jan-auer jan-auer commented Jul 8, 2020

Applies the ClockDriftProcessor to correct future timestamps even if the clock drift is under the 55 minute threshold. The default limit is 60 seconds. Note that this only applies to timestamp normalization, and not to regular clock drift correction.

Ref #634

@jan-auer jan-auer requested review from untitaker and a team July 8, 2020 12:19
@jan-auer jan-auer self-assigned this Jul 8, 2020
@jan-auer
Copy link
Member Author

jan-auer commented Jul 8, 2020

This was detected by this test in Sentry:

https://github.com/getsentry/sentry/blob/f952fedefe679d632077a2b334a913e9e68cfd91/tests/sentry/event_manager/test_validate_data.py#L17

jan-auer added 2 commits July 8, 2020 14:33
@jan-auer
Merge branch 'master' into fix/future-timestamp
5b92cc9 
* master:
  fix(server): Forward outcomes in processing mode (#653)
@jan-auer
meta: Changelog
685b96b
@jan-auer jan-auer merged commit 76884bd into master Jul 8, 2020
@jan-auer jan-auer deleted the fix/future-timestamp branch July 8, 2020 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@untitaker untitaker untitaker approved these changes

Assignees

@jan-auer jan-auer

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jan-auer @untitaker