feat(processing): Extract event timestamp from minidump #662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
reviewed
Jul 16, 2020
untitaker
reviewed
Jul 16, 2020
added 4 commits
July 17, 2020 17:05
If a minidump event is received, this extracts the timestamp from the minidump and sets it as the event's timestamp.
We want to do the counters separately in a followup. Logging errors shows up as errors in sentry, so avoid doing this.
flub
force-pushed
the
feat/minidump-timestamp
branch
from
0b03c96 to
c4f41f1
Compare
This is why testing code should have tests. Still not adding them because I like to hurt myself some more first in the misguided believe this will save me time.
There have been some changes and the functionality is much better. This allows us to avoid the Cursor wrapping which is slow in debug builds.
jan-auer
changed the title
* master: doc: Clarify that managed mode is not GA release: 20.7.2 ref(server): Increase maximum attachment size to 100MiB (#671) ref(config): Clear up confusion around mebibytes (#670) meta: Changelog feat(server): Report metrics for upstream connections (#669) test: Fix flakey outcomes test (#668) ref(transactions): Normalize transaction spans into an array (#667) release: 20.7.1
jan-auer
approved these changes
Jul 23, 2020
There was a problem hiding this comment.
Thanks a bunch!
cc @untitaker: this allows us to remove validate_and_set_timestamp in Sentry.
|
hell yea |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a minidump event is received, this extracts the timestamp from the
minidump and sets it as the event's timestamp.