ref(pii): Use external utf16string crate #807
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The relay-wstring crate has been split off to the utf16string crate,
this switches our code over.
Unsurprisingly straightforward. Caveat is that this is not 100% the same code backing this: the external crate uses the ByteOrder trait to read and write u16s instead of using
u16::from_le_bytes()
andu16::to_le_bytes()
. Because of that there's some more panicking code in there, but the perf impact of that seemed very small in microbenchmarks. And the whole thing has seen less review. Seems to work fine though.#skip-changelog