fix(forwarding): Change HTTP response for upstream timeouts from 502 to 504 #859
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jan-auer
reviewed
Nov 30, 2020
| @@ -75,6 +75,7 @@ impl ResponseError for ForwardedUpstreamRequestError { | |||
| HttpError::ActixPayload(e) => e.error_response(), | |||
| HttpError::ActixJson(e) => e.error_response(), | |||
| }, | |||
| UpstreamRequestError::SendFailed(_) => HttpResponse::GatewayTimeout().finish(), | |||
There was a problem hiding this comment.
This should be a 500 instead of a 502, since it indicates a failure to build the request, correct?
There was a problem hiding this comment.
this error actually needs more destructuring
There was a problem hiding this comment.
Can we instead map all relevant errors to UpstreamRequestError kinds? It is rather unfortunate having to destructure errors like this since it is too easy to miss cases, as shown by this PR.
jan-auer
approved these changes
Dec 21, 2020
RaduW
approved these changes
Jan 14, 2021
|
@untitaker can you update this? |
untitaker
force-pushed
the
fix/forwarding-gateway-timeout
branch
from
e34755d to
e23f36f
Compare
untitaker
changed the title
jan-auer
approved these changes
Mar 18, 2021
RaduW
approved these changes
Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix RELAY-93