feat: Enable use of multiple value types per field #882
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ability to assign multiple value types to a protocol type. For example (part of the patch):
This allows us to fix a long-standing issue with logentry.formatted,
which is supposed to be addressible by $string as well as
$logentry.formatted as well as $message.
It also makes a bit of code in minidump attachment processing simpler,
and removes an obstacle in introducing valuetypes in a
backwards-compatible manner.
For future consideration we may change the behavior of the derive on
newtypes to append to the list of valuetypes rather than replace them,
such that the actual syntactic change in logentry.rs is not necessary
(as the Message wraps a String already). Similarly one could make all
structs-with-fields addressible under $object.