ref(config): Rename envelope buffer config fields #985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tonyo there's a regression test checked in. Please verify that you're on board with this change. |
untitaker
approved these changes
Apr 23, 2021
| relay_expiry: 3600, // 1 hour | ||
| event_expiry: 600, // 10 minutes | ||
| event_buffer_size: 1000, | ||
| relay_expiry: 3600, // 1 hour |
There was a problem hiding this comment.
fwiw this alignment used to be the same from L588-595
There was a problem hiding this comment.
Yeah, this is all rustfmt doing its thing. It aligns consecutive comments, but not all in a group.
tonyo
approved these changes
Apr 23, 2021
* master: ref(server): Rename components dealing with envelopes (#984)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renames two configuration fields since they apply to all envelopes. The former naming is still supported and soft-deprecated:
cache.event_buffer_size->cache.envelope_buffer_sizecache.event_expiry->cache.envelope_expirySee also #984 for related changes
This will require an update in sentry-docs