Check for latest commit before install.sh

[aminvakil]

Fixes #925

However this would prevent from running in isolated (without Internet) environments.

Credit: https://stackoverflow.com/a/25109122/3835210

[aminvakil]

Current state has problems when running on tags...

[BYK]

Quite sure this would break all the releases. This should be limited to nightly builds only and since we don't promote using those anymore, I'd say fixing #925 is more hassle than it is worth.

[BYK]

This also assumes the repo is run from a git checkout, which is not the case (for the e2e tests Sentry runs using this repo for instance)

[aminvakil]

Quite sure this would break all the releases. This should be limited to nightly builds only and since we don't promote using those anymore, I'd say fixing #925 is more hassle than it is worth.

This checks if master branch has been checked out, otherwise skip, I can't understand what you mean by breaking all the releases.

This also assumes the repo is run from a git checkout, which is not the case (for the e2e tests Sentry runs using this repo for instance)

Thanks! Fixed by bcf256e.

[BYK]

This checks if master branch has been checked out, otherwise skip, I can't understand what you mean by breaking all the releases.

Ah, sorry I missed that logic. Doing another review now.

[BYK]

Requesting change for comments and a bypass logic, otherwise seems good.

There's also a failure in integration tests but don't know if this is relevant or not.

[BYK]

Some comments here explaining the logic would be very beneficial.

I also think we should have a flag (CLI or env variable) to bypass this logic as I can easily see this becoming a nuisance for people maintaining their custom versions.

[aminvakil]

Requesting change for comments and a bypass logic, otherwise seems good.

👍

There's also a failure in integration tests but don't know if this is relevant or not.

I think it's related to #1171

[aminvakil]

I don't like --not-latest-commit switch, any suggestions?

[chadwhitacre]

Can we fold into the existing structure?

• command line switch goes in parse-cli.sh
• new file called install/check-latest-commit.sh or somesuch

Wdyt?

[chadwhitacre]

I don't like --not-latest-commit switch, any suggestions?

Maybe --skip-commit-check? 🤔

[aminvakil]

Can we fold into the existing structure?

* command line switch goes in `parse-cli.sh`

* new file called `install/check-latest-commit.sh` or somesuch

Wdyt?

Nice idea.