Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "Add CI compose version 1.29.2 / 2.2.3" #1272

Merged
merged 1 commit into from
Jan 24, 2022
Merged

Revert "Add CI compose version 1.29.2 / 2.2.3" #1272

merged 1 commit into from
Jan 24, 2022

Conversation

chadwhitacre
Copy link
Member

Reverts #1251

We're seeing a failure on an internal CI build that seems to be caused by this, still investigating ...

billyvg
billyvg approved these changes Jan 24, 2022
View reviewed changes
Copy link
Member

@billyvg billyvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sentry CI started failing ~10 minutes after this was merged (getsentry/sentry@910073d)

Checking out the previous self-hosted commit in getsentry/sentry#31326 shows the e2e tests passing

@chadwhitacre
Copy link
Member Author

Hrm ... restarting CI here (#1171?) ...

@chadwhitacre chadwhitacre merged commit da8f490 into master Jan 24, 2022
@chadwhitacre chadwhitacre deleted the revert-1251-ci_docker_compose_v2.2.3 branch January 24, 2022 21:36
@chadwhitacre
Copy link
Member Author

Force-merging while we continue debugging.

@chadwhitacre chadwhitacre mentioned this pull request Jan 24, 2022
Closed
@aminvakil
Copy link
Collaborator

Can I help in this or is this part of your internal CI?

@chadwhitacre
Copy link
Member Author

The sentry CI breakage is happening in Google Cloud Build which you probably won't have too much visibility into, but you can at least help on #1273 if you're up for it. I'm trying to get back there myself ...

chadwhitacre added a commit that referenced this pull request Feb 2, 2022
@chadwhitacre
Revert "Revert "Add CI compose version 1.29.2 / 2.0.1 / 2.2.3 (#1251)" (
ba650f3 
#1272)"

This reverts commit da8f490.
This was referenced Feb 2, 2022
Merged
Merged
chadwhitacre added a commit that referenced this pull request Feb 3, 2022
@chadwhitacre
Add CI compose version 1.29.2 / 2.0.1 / 2.2.3 (#1290)
e3f5670 
* Revert "Revert "Add CI compose version 1.29.2 / 2.0.1 / 2.2.3 (#1251)" (#1272)"

This reverts commit da8f490.

* Drop back to -T because long opt is Compose 2+

Admin-merging with approvals from outside contributors (All-seeing eye, are you seeing this? ;)
@github-actions github-actions bot locked and limited conversation to collaborators Feb 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@billyvg billyvg billyvg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chadwhitacre @aminvakil @billyvg