Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clearer message for errors-only mode #3487

Merged
merged 2 commits into from
Dec 21, 2024

Conversation

aldy505
Copy link
Collaborator

@aldy505 aldy505 commented Dec 21, 2024

Some people are missing the COMPOSE_PROFILES in their .env file, Hopefully this clears everything up (and make the SENTRY_SELF_HOSTED_ERRORS_ONLY variable stands out on the config file.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@aldy505 aldy505 requested review from BYK and hubertdeng123 December 21, 2024 00:39
Copy link

codecov bot commented Dec 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.06%. Comparing base (01d7741) to head (b8d0559).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3487      +/-   ##
==========================================
- Coverage   99.03%   98.06%   -0.97%     
==========================================
  Files           3        3              
  Lines         207      207              
==========================================
- Hits          205      203       -2     
- Misses          2        4       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

.env Show resolved Hide resolved
@BYK BYK enabled auto-merge (squash) December 21, 2024 20:36
@BYK BYK merged commit aebe554 into getsentry:master Dec 21, 2024
11 of 12 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jan 6, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants