-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(releases): Update docs to use GitHub App instead of service account PAT #11805
base: master
Are you sure you want to change the base?
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
Bundle ReportChanges will increase total bundle size by 312 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
|
||
You can do this self-service via the settings page of your repository: | ||
`https://github.com/getsentry/REPONAME_HERE/settings/access` | ||
|
||
## Create ruleset for the repo | ||
|
||
Download and save the [default ruleset template](https://docs.sentry.io/json/Default_ruleset.json) as a JSON file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This url s 404ing for me, is it correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I see the issue here, let's change it to a relative url:
Download and save the [default ruleset template](https://docs.sentry.io/json/Default_ruleset.json) as a JSON file. | |
Download and save the [default ruleset template](/json/Default_ruleset.json) as a JSON file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@coolguyzone the changes I'm making to are on develop.sentry.dev, and the JSON is hosted on docs.sentry.io, hence I don't think the relative URL will work.
I would love to move the JSON over under the develop domain, but I'm not sure how to do that, any suggestions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, fair point. In that case, the absolute URL makes sense.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, I added a suggestion to reformat one of the links.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Liza Mock <[email protected]>
Will be waiting for approval on the devinfra side on this before rolling this out |
DESCRIBE YOUR PR
We are planning to replace the current usage of getsentry-release bot with a GitHub App, this PR will update the docs to include updated code template.
More details: https://www.notion.so/sentry/DACI-Replace-GitHub-bot-accounts-with-GitHub-Apps-getsentry-release-15109965d1204a91b9be71c49e8b66e0?pvs=4
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes: