Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(expo-router): improve example #11812

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

moritzlang
Copy link

@moritzlang moritzlang commented Nov 13, 2024

DESCRIBE YOUR PR

Fixes typo leading to "method not found" when copy pasting the example.
Also uses a more descriptive function to determine if the app is running in Expo Go replacing the comment.

IS YOUR CHANGE URGENT?

  • Urgent deadline (GA date, etc.):
  • Other deadline:
  • None: Not urgent, can wait up to 1 week+

PRE-MERGE CHECKLIST

Make sure you've checked the following before merging your changes:

  • Checked Vercel preview for correctness, including links
  • PR was reviewed and approved by any necessary SMEs (subject matter experts)
  • PR was reviewed and approved by a member of the Sentry docs team

LEGAL BOILERPLATE

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

Copy link

vercel bot commented Nov 13, 2024

@moritzlang is attempting to deploy a commit to the Sentry Team on Vercel.

A member of the Team first needs to authorize it.

@moritzlang moritzlang changed the title fix typo docs(expo-router): fix typo Nov 13, 2024
Uses a more descriptive function if the app is running in Expo Go instead of the comment.
@moritzlang moritzlang changed the title docs(expo-router): fix typo docs(expo-router): improve example Nov 13, 2024
Copy link

vercel bot commented Nov 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 13, 2024 7:14pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 7:14pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 13, 2024 7:14pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant