Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(apple): Add onboarding source context Option #11819

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

brustolin
Copy link
Contributor

Added source-coxtext as onboarding component option in order to manipulate the code snippet related to upload debug symbols.

closes #11810

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sentry-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 3:31pm
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
changelog ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 3:31pm
develop-docs ⬜️ Ignored (Inspect) Visit Preview Nov 14, 2024 3:31pm

Copy link

codecov bot commented Nov 14, 2024

Bundle Report

Changes will increase total bundle size by 393 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
sentry-docs-server-cjs 8.59MB 193 bytes (0.0%) ⬆️
sentry-docs-client-array-push 8.94MB 200 bytes (0.0%) ⬆️

Copy link
Member

@philipphofmann philipphofmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this, but the current approach is quite confusing to me right now.

Comment on lines 3 to 7
You can also upload your code for source context. This feature allows Sentry to display snippets of your code next to the event stack traces.

<OnboardingOptionButtons
options={[{ id:"source-context", checked: false }]}
/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

h: I think this should be directly above the code snippets. The experience is quite confusing to me now as it's I have no clue what the checkbox is doing, cause I don't see the code snippets.

CleanShot 2024-11-14 at 16 10 11@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Highlight better the effects of the "include sources" option
2 participants