Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SR] Fix memory leak in Compose masking #3985

Merged
merged 12 commits into from
Dec 16, 2024
Merged

Conversation

romtsn
Copy link
Member

@romtsn romtsn commented Dec 12, 2024

📜 Description

Use WeakReference to store root coordinates and add a test for leaks in replay

💡 Motivation and Context

Closes #3915

💚 How did you test it?

Manually + automated

📝 Checklist

  • I added tests to verify the changes.
  • No new PII added or SDK only sends newly added PII if sendDefaultPII is enabled.
  • I updated the docs if needed.
  • I updated the wizard if needed.
  • Review from the native team if needed.
  • No breaking change or entry added to the changelog.
  • No breaking change for hybrid SDKs or communicated to hybrid SDKs.

🔮 Next steps

Copy link
Contributor

github-actions bot commented Dec 12, 2024

Performance metrics 🚀

  Plain With Sentry Diff
Startup time 617.60 ms 741.08 ms 123.48 ms
Size 1.70 MiB 2.36 MiB 672.21 KiB

Previous results on branch: rz/fix/session-replay-leak

Startup times

Revision Plain With Sentry Diff
ad8d4f6 436.69 ms 535.08 ms 98.39 ms
8ba5fb7 407.10 ms 443.43 ms 36.33 ms
6b64771 388.73 ms 416.23 ms 27.50 ms
216c007 405.88 ms 407.52 ms 1.64 ms
fc84278 400.59 ms 424.42 ms 23.83 ms

App size

Revision Plain With Sentry Diff
ad8d4f6 1.70 MiB 2.36 MiB 672.21 KiB
8ba5fb7 1.70 MiB 2.36 MiB 672.25 KiB
6b64771 1.70 MiB 2.36 MiB 672.25 KiB
216c007 1.70 MiB 2.36 MiB 672.21 KiB
fc84278 1.70 MiB 2.36 MiB 672.25 KiB

@romtsn romtsn changed the title Fix memory leak in Compose masking for Session Replay [SR] Fix memory leak in Compose masking Dec 16, 2024
Copy link
Member

@stefanosiano stefanosiano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@romtsn romtsn merged commit 00f91f4 into main Dec 16, 2024
33 checks passed
@romtsn romtsn deleted the rz/fix/session-replay-leak branch December 16, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Session Replay for Compose leak
2 participants