-
-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SR] Fix memory leak in Compose masking #3985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romtsn
requested review from
adinauer,
stefanosiano and
markushi
as code owners
December 12, 2024 22:38
Performance metrics 🚀
|
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ad8d4f6 | 436.69 ms | 535.08 ms | 98.39 ms |
8ba5fb7 | 407.10 ms | 443.43 ms | 36.33 ms |
6b64771 | 388.73 ms | 416.23 ms | 27.50 ms |
216c007 | 405.88 ms | 407.52 ms | 1.64 ms |
fc84278 | 400.59 ms | 424.42 ms | 23.83 ms |
App size
Revision | Plain | With Sentry | Diff |
---|---|---|---|
ad8d4f6 | 1.70 MiB | 2.36 MiB | 672.21 KiB |
8ba5fb7 | 1.70 MiB | 2.36 MiB | 672.25 KiB |
6b64771 | 1.70 MiB | 2.36 MiB | 672.25 KiB |
216c007 | 1.70 MiB | 2.36 MiB | 672.21 KiB |
fc84278 | 1.70 MiB | 2.36 MiB | 672.25 KiB |
romtsn
changed the title
Fix memory leak in Compose masking for Session Replay
[SR] Fix memory leak in Compose masking
Dec 16, 2024
stefanosiano
approved these changes
Dec 16, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📜 Description
Use
WeakReference
to store root coordinates and add a test for leaks in replay💡 Motivation and Context
Closes #3915
💚 How did you test it?
Manually + automated
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps