-
-
Notifications
You must be signed in to change notification settings - Fork 443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(android-ndk): add api for getting debug images by addresses #4089
Open
buenaflor
wants to merge
14
commits into
main
Choose a base branch
from
feat/internal-sdk-debug-image-fetching-per-stacktrace
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat(android-ndk): add api for getting debug images by addresses #4089
buenaflor
wants to merge
14
commits into
main
from
feat/internal-sdk-debug-image-fetching-per-stacktrace
+159
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buenaflor
requested review from
adinauer,
romtsn,
stefanosiano and
markushi
as code owners
January 21, 2025 22:53
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- add api for getting debug images by addresses ([#4089](https://github.com/getsentry/sentry-java/pull/4089)) If none of the above apply, you can opt out of this check by adding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
question: can I push this change onto a v7 branch? We cannot bump to Android v8 at this moment because we also depend on min android api 19 which has been bumped to 21 here. if not possible we'll mark this as a Flutter v9 feature
📜 Description
Adds debug images loader API for getting images by addresses
💡 Motivation and Context
On Flutter we are currently loading all available debug images which can sometimes range up to 300 images but in most cases only 1 is actually used so this is much more efficient and the envelope is therefore smaller
Closes #3925
💚 How did you test it?
Unit test, e2e test with Flutter app
📝 Checklist
sendDefaultPII
is enabled.🔮 Next steps