feat(core)!: Remove deprecated request data methods (#14896)

Removes `extractRequestData`, `addRequestDataToEvent` and `extractPathForTransaction`. ref #14268
getsentry · Jan 3, 2025 · d951476 · d951476
1 parent 64d36a9
commit d951476
Show file tree

Hide file tree

Showing 14 changed files with 14 additions and 1,089 deletions.
diff --git a/docs/migration/v8-to-v9.md b/docs/migration/v8-to-v9.md
@@ -144,6 +144,9 @@ Sentry.init({
 - The `urlEncode` method has been removed. There is no replacement.
 - The `getDomElement` method has been removed. There is no replacement.
 - The `memoBuilder` method has been removed. There is no replacement.
+- The `extractRequestData` method has been removed. Manually extract relevant data off request instead.
+- The `addRequestDataToEvent` method has been removed. Use `addNormalizedRequestDataToEvent` instead.
+- The `extractPathForTransaction` method has been removed. There is no replacement.
 
 #### Other/Internal Changes
 

diff --git a/packages/astro/src/index.server.ts b/packages/astro/src/index.server.ts
@@ -11,8 +11,6 @@ export {
   addBreadcrumb,
   addEventProcessor,
   addIntegration,
-  // eslint-disable-next-line deprecation/deprecation
-  addRequestDataToEvent,
   amqplibIntegration,
   anrIntegration,
   disableAnrDetectionForCallback,
@@ -38,8 +36,6 @@ export {
   endSession,
   expressErrorHandler,
   expressIntegration,
-  // eslint-disable-next-line deprecation/deprecation
-  extractRequestData,
   extraErrorDataIntegration,
   fastifyIntegration,
   flush,

diff --git a/packages/aws-serverless/src/index.ts b/packages/aws-serverless/src/index.ts
@@ -42,11 +42,7 @@ export {
   flush,
   close,
   getSentryRelease,
-  // eslint-disable-next-line deprecation/deprecation
-  addRequestDataToEvent,
   DEFAULT_USER_INCLUDES,
-  // eslint-disable-next-line deprecation/deprecation
-  extractRequestData,
   createGetModuleFromFilename,
   anrIntegration,
   disableAnrDetectionForCallback,

diff --git a/packages/bun/src/index.ts b/packages/bun/src/index.ts
@@ -62,11 +62,7 @@ export {
   flush,
   close,
   getSentryRelease,
-  // eslint-disable-next-line deprecation/deprecation
-  addRequestDataToEvent,
   DEFAULT_USER_INCLUDES,
-  // eslint-disable-next-line deprecation/deprecation
-  extractRequestData,
   createGetModuleFromFilename,
   anrIntegration,
   disableAnrDetectionForCallback,

diff --git a/packages/core/src/integrations/requestdata.ts b/packages/core/src/integrations/requestdata.ts
@@ -1,10 +1,6 @@
 import { defineIntegration } from '../integration';
 import type { IntegrationFn } from '../types-hoist';
-import {
-  type AddRequestDataToEventOptions,
-  addNormalizedRequestDataToEvent,
-  addRequestDataToEvent,
-} from '../utils-hoist/requestdata';
+import { type AddRequestDataToEventOptions, addNormalizedRequestDataToEvent } from '../utils-hoist/requestdata';
 
 export type RequestDataIntegrationOptions = {
   /**
@@ -25,12 +21,6 @@ export type RequestDataIntegrationOptions = {
           email?: boolean;
         };
   };
-
-  /**
-   * Whether to identify transactions by parameterized path, parameterized path with method, or handler name.
-   * @deprecated This option does not do anything anymore, and will be removed in v9.
-   */
-  transactionNamingScheme?: 'path' | 'methodPath' | 'handler';
 };
 
 const DEFAULT_OPTIONS = {
@@ -93,13 +83,7 @@ const _requestDataIntegration = ((options: RequestDataIntegrationOptions = {}) =
         return event;
       }
 
-      // TODO(v9): Eventually we can remove this fallback branch and only rely on the normalizedRequest above
-      if (!request) {
-        return event;
-      }
-
-      // eslint-disable-next-line deprecation/deprecation
-      return addRequestDataToEvent(event, request, addRequestDataOptions);
+      return event;
     },
   };
 }) satisfies IntegrationFn;
@@ -116,8 +100,6 @@ function convertReqDataIntegrationOptsToAddReqDataOpts(
   integrationOptions: Required<RequestDataIntegrationOptions>,
 ): AddRequestDataToEventOptions {
   const {
-    // eslint-disable-next-line deprecation/deprecation
-    transactionNamingScheme,
     include: { ip, user, ...requestOptions },
   } = integrationOptions;
 
@@ -148,7 +130,6 @@ function convertReqDataIntegrationOptsToAddReqDataOpts(
       ip,
       user: addReqDataUserOpt,
       request: requestIncludeKeys.length !== 0 ? requestIncludeKeys : undefined,
-      transaction: transactionNamingScheme,
     },
   };
 }
diff --git a/packages/core/src/utils-hoist/index.ts b/packages/core/src/utils-hoist/index.ts
@@ -68,12 +68,6 @@ export type { PromiseBuffer } from './promisebuffer';
 export {
   DEFAULT_USER_INCLUDES,
   addNormalizedRequestDataToEvent,
-  // eslint-disable-next-line deprecation/deprecation
-  addRequestDataToEvent,
-  // eslint-disable-next-line deprecation/deprecation
-  extractPathForTransaction,
-  // eslint-disable-next-line deprecation/deprecation
-  extractRequestData,
   winterCGHeadersToDict,
   winterCGRequestToRequestData,
   httpRequestToRequestData,