Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): Support new async APIs (headers(), params, searchParams) #13828

Merged
merged 8 commits into from
Sep 30, 2024

Conversation

lforst
Copy link
Member

@lforst lforst commented Sep 30, 2024

Changes in Next.js vercel/next.js#68812

This PR is mostly just adjusting our E2E tests so they don't fail while building.

Additionally, we had to update the withServerActionInstrumentation API in a semver-minor way so you can pass a promise to the headers option. The ReadonlyHeaders type isn't exposed in all Next.js versions so for now I typed it as any.

Resolves #13805
Resolves #13779
Resolves #13780

@lforst lforst changed the title test(nextjs): Make tests work with new async APIs feat(nextjs): Support new async APIs (headers(), params, searchParams) Sep 30, 2024
@lforst lforst marked this pull request as ready for review September 30, 2024 11:06
@lforst lforst requested a review from chargome September 30, 2024 11:06
@lforst lforst merged commit ca19f34 into develop Sep 30, 2024
131 checks passed
@lforst lforst deleted the lforst-fix-canary-test-api branch September 30, 2024 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nextjs-app-dir (canary) Test Failed nextjs-14 (canary) Test Failed nextjs-15 (canary) Test Failed
2 participants