feat(core): Deprecate parseUrl
#14404
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
size-limit report 📦
|
❌ 17 Tests Failed:
View the top 3 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
AbhiPrasad
approved these changes
Nov 21, 2024
mydea
reviewed
Nov 21, 2024
| attributes['server.address'] = parsedUrl.host; | ||
| try { | ||
| // The URL constructor can throw when there is no protocol or host. | ||
| const parsedUrl = new URL(resourceUrl); |
There was a problem hiding this comment.
can resourceUrl be a path-only, without a host? 🤔 just double checking.
mydea
reviewed
Nov 21, 2024
| if (parsedUrl.protocol) { | ||
| attributes['url.scheme'] = parsedUrl.protocol.split(':').pop(); // the protocol returned by parseUrl includes a :, but OTEL spec does not, so we remove it. | ||
| } | ||
| if (parsedUrl.host) { |
mydea
reviewed
Nov 21, 2024
| try { | ||
| // The URL constructor can throw when there is no protocol or host. | ||
| const parsedUrl = new URL(resourceUrl); | ||
| if (parsedUrl.protocol) { |
mydea
reviewed
Nov 21, 2024
| let parsedFrom = from ? parseUrl(from) : undefined; | ||
| const parsedTo = parseUrl(to); | ||
| let parsedFrom = from ? new URL(from, DUMMY_URL_BASE) : undefined; | ||
| const parsedTo = new URL(to, DUMMY_URL_BASE); |
There was a problem hiding this comment.
we should always try-catch this, to avoid stuff blowing up IMHO!
mydea
reviewed
Nov 21, 2024
| const attributes: SpanAttributes = { | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_ORIGIN]: 'auto.http.bun.serve', | ||
| [SEMANTIC_ATTRIBUTE_HTTP_REQUEST_METHOD]: request.method || 'GET', | ||
| [SEMANTIC_ATTRIBUTE_SENTRY_SOURCE]: 'url', | ||
| }; | ||
|
|
||
| const parsedUrl = new URL(request.url, DUMMY_URL_BASE); |
|
IMHO this is fine, but:
Generally I wonder if it would not be easier/better to just let the method be and just rewrite it to use |
I had the exact same thought today, the only problem I had with it was that it is maybe too generic to be exported as API from a Sentry package. At the same time, nobody probably cares. |
|
Let's keep this funciton and replace the implementation with URL in a non-breaking way. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #14267
Deprecates and removes usages of
parseUrlwhich can be replaced with the URL constructor with our current version support.