Skip to content
This repository has been archived by the owner on Dec 4, 2023. It is now read-only.

Add SENTRY_REPOSITORY environment variable #46

Merged
merged 5 commits into from
Feb 7, 2022

Conversation

lewisjared
Copy link
Contributor

Allow users to override the repository name passed to the cli.
This is useful for gitlab users where the repository name is not necessarily the same
as the URL (#21)

Allow users to override the respository name passed to the cli.
This is useful for gitlab users where the the repository name is not necessarily the same
as the url (getsentry#21)
@cvburgess
Copy link

Any chance this might get merged? Our team is on GitLab and this prevents us from using the plugin 🙁

@bristoljon
Copy link

@lewisjared Did you happen to publish this fixed version to npm? Just wondering if we can try the fix out in meantime and switch back when this has been merged.

We are also blocked from using the plugin due to repo being on gitlab.com.

With this and the fact that Netlify's new deploy preview feature is only available on github.com so far, starting to think it would be worth switching over..

@alias-mac
Copy link

Any chance to get this merged? I'm using gitlab integration too and keep getting errors on this.
I think this has been open for quite some time and plenty of information given in #21.
@jonesphillip is there a way that paying customers (like me) can push this through Sentry support? Thanks!

@leeandher leeandher self-assigned this Jan 27, 2022
Copy link
Member

@leeandher leeandher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for your PR! Sorry it took so long to get it in front of some eyes 👀. Code-wise, looks great, just a few docs changes we'd like to see before merging. Please feel free to re-assign me when the changes are made!

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
manifest.yml Outdated Show resolved Hide resolved
@leeandher leeandher assigned lewisjared and unassigned leeandher Jan 27, 2022
@alias-mac
Copy link

@lewisjared are you able to make the changes? If you can't let me know, so I can create another PR with the recommended changes and get this in. Thanks!

@leeandher
Copy link
Member

@lewisjared I went ahead and addressed the review myself since they were small wording changes. Thank you for the PR and again, apologies it took so long to get eyes on this. We have a few other changes we want to make before a new release, but thank you for your contribution!

@leeandher leeandher merged commit c94d8a9 into getsentry:master Feb 7, 2022
@leeandher
Copy link
Member

Will be released in v1.1.1 👍

@alias-mac
Copy link

@leeandher do you know when that version will be published to https://github.com/netlify/plugins?
I see that the latest update was done awhile ago and was 1.1.0: netlify/plugins#281.

@leeandher
Copy link
Member

@alias-mac I've opened a PR to update the version on Netlify's end, I wasn't aware of that step in deploying, thank you!

netlify/plugins#671

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants