-
-
Notifications
You must be signed in to change notification settings - Fork 17
Add SENTRY_REPOSITORY environment variable #46
Conversation
Allow users to override the respository name passed to the cli. This is useful for gitlab users where the the repository name is not necessarily the same as the url (getsentry#21)
Any chance this might get merged? Our team is on GitLab and this prevents us from using the plugin 🙁 |
@lewisjared Did you happen to publish this fixed version to npm? Just wondering if we can try the fix out in meantime and switch back when this has been merged. We are also blocked from using the plugin due to repo being on gitlab.com. With this and the fact that Netlify's new deploy preview feature is only available on github.com so far, starting to think it would be worth switching over.. |
Any chance to get this merged? I'm using gitlab integration too and keep getting errors on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for your PR! Sorry it took so long to get it in front of some eyes 👀. Code-wise, looks great, just a few docs changes we'd like to see before merging. Please feel free to re-assign me when the changes are made!
@lewisjared are you able to make the changes? If you can't let me know, so I can create another PR with the recommended changes and get this in. Thanks! |
@lewisjared I went ahead and addressed the review myself since they were small wording changes. Thank you for the PR and again, apologies it took so long to get eyes on this. We have a few other changes we want to make before a new release, but thank you for your contribution! |
Will be released in v1.1.1 👍 |
@leeandher do you know when that version will be published to https://github.com/netlify/plugins? |
@alias-mac I've opened a PR to update the version on Netlify's end, I wasn't aware of that step in deploying, thank you! |
Allow users to override the repository name passed to the cli.
This is useful for gitlab users where the repository name is not necessarily the same
as the URL (#21)