Skip to content

Commit

Permalink
feat(ui): Update Loader Script UI to accomodate v8 (#73836)
Browse files Browse the repository at this point in the history
This updates the UI of the loader script settings to accomodate v8.

Part of getsentry/sentry-javascript#12187
  • Loading branch information
mydea authored and priscilawebdev committed Jul 11, 2024
1 parent ac4f61c commit 7cdf57c
Showing 1 changed file with 10 additions and 2 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -226,8 +226,16 @@ export function LoaderSettings({keyId, orgSlug, project, data, updateData}: Prop
? t('Only available in SDK version 7.x and above')
: data.dynamicSdkLoaderOptions.hasReplay
? tct(
'When using Replay, the loader will load the ES6 bundle instead of the ES5 bundle. The default configurations are [codeReplay:replaysSessionSampleRate: 0.1] and [codeError:replaysOnErrorSampleRate: 1]. [configDocs:Read the docs] to learn how to configure this.',
`[es5Warning]The default configurations are [codeReplay:replaysSessionSampleRate: 0.1] and [codeError:replaysOnErrorSampleRate: 1]. [configDocs:Read the docs] to learn how to configure this.`,
{
es5Warning:
// latest is deprecated but resolves to v7
data.browserSdkVersion === '7.x' ||
data.browserSdkVersion === 'latest'
? t(
'When using Replay, the loader will load the ES6 bundle instead of the ES5 bundle.'
) + ' '
: '',
codeReplay: <code />,
codeError: <code />,
configDocs: (
Expand Down Expand Up @@ -265,5 +273,5 @@ export function LoaderSettings({keyId, orgSlug, project, data, updateData}: Prop
}

function sdkVersionSupportsPerformanceAndReplay(sdkVersion: string): boolean {
return sdkVersion === 'latest' || sdkVersion === '7.x';
return sdkVersion === 'latest' || sdkVersion === '7.x' || sdkVersion === '8.x';
}

0 comments on commit 7cdf57c

Please sign in to comment.