Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added basic span handling in store #12188

Closed
wants to merge 2 commits into from
Closed

Conversation

mitsuhiko
Copy link
Member

This is not really useful as it stands, I think we need to rethink this a bit
but it's good enough for now I belive.

This depends on getsentry/relay#179

@mitsuhiko
Copy link
Member Author

I hacked this together to make session store work but I'm not sure this makes any sense for a longer term solution.

@mitsuhiko
Copy link
Member Author

@alex-hofsteede There is a dummy function that gets invoked now doing nothing.

@HazAT
Copy link
Member

HazAT commented Mar 4, 2019

@mitsuhiko The rust normalization strips away spans.

{u'_meta': {u'spans': {u'': {u'err': [u'invalid_attribute']}}}, ...

@mitsuhiko
Copy link
Member Author

@HazAT any chance you are running an old version of semaphore? Spans were added a while back: getsentry/relay@aa3b92b

@HazAT
Copy link
Member

HazAT commented Mar 4, 2019

@mitsuhiko I just ran make develop on this branch.
It's probably because I don't have semaphore installed with editable or something.

@mitsuhiko
Copy link
Member Author

I think that might be because this branch is outdated in comparison to master. Merge master in, make develop and that should fix it (i hope).

@HazAT
Copy link
Member

HazAT commented Mar 5, 2019

That fixed it, rebased master and force pushed.

@alex-hofsteede
Copy link
Contributor

@mitsuhiko I'm going to take this over and see if I can get the events sent into eventstream/kafka.

@mitsuhiko mitsuhiko closed this Sep 5, 2019
@mitsuhiko mitsuhiko deleted the feature/spans branch September 5, 2019 12:34
@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants